Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the layout of the sidebar #504

Merged
merged 5 commits into from
Mar 15, 2024
Merged

Conversation

huihuisang
Copy link
Contributor

@huihuisang huihuisang commented Feb 18, 2024

Modification reason:
The sidebar UI layout looks a bit crowded and asymmetric. ( Maybe it's just my personal subjective feeling. :) )

This PR makes the following changes:

  1. Added a default icon with transparency to distinguish between downloaded and undownloaded states, and eliminate the blank space on the left when not downloaded.
  2. When not downloaded, the version name is centered.
  3. Moved platforms to the upper left corner to reduce the display of mismatched buttons at the bottom.

Before:
Screenshot 2024-02-18 at 14 41 37

After:
Screenshot 2024-03-10 at 15 39 00

Copy link
Contributor

@MattKiazyk MattKiazyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huihuisang thanks for the work you've done. Totally love the new icons and how it looks.

Can I ask that you leave the platforms button as it was in the bottom left vs at the top toolbar.

Because the platforms window is completely separate, having at the top toolbar doesn't make sense as that toolbar filters, searches, etc the list.

Thanks!

@rtharston
Copy link

Because the platforms window is completely separate, having at the top toolbar doesn't make sense as that toolbar filters, searches, etc the list.

That is a fair point, but it is a bit large and feels a little out of place.
Maybe instead of putting the button in the left section of the toolbar, it could go on the right section, near the account and settings buttons. The settings button also opens a new window.

What do you think?

@MattKiazyk
Copy link
Contributor

Because the platforms window is completely separate, having at the top toolbar doesn't make sense as that toolbar filters, searches, etc the list.

That is a fair point, but it is a bit large and feels a little out of place. Maybe instead of putting the button in the left section of the toolbar, it could go on the right section, near the account and settings buttons. The settings button also opens a new window.

What do you think?

I'm still leaning towards having it on the left side vs having another icon on the right. Perhaps smaller?

@rtharston
Copy link

Hmm... I'm not UI designer, so I don't have the tools to mock up some options.

I think my main issue with the current Platforms button is that it is alone and feels out of place. Making it big makes it easy to spot, but why is it in the list of Xcode versions? 🤷‍♂️

Thinking about that gave me another thought. Why do the platforms need to be a different window? Could there be a tab selector instead that switched between Xcode and Platform in the left column? The platforms window is just showing a list after all, and that list could fit there.
That then leads to the question of what to put in the detail view when a platform is selected.

Okay, sanity check. I just opened Xcodes to remind myself what is in the Platforms window. It is only the installed platforms. I think my tabbed left column idea only makes sense if it shows all available platforms, similar to the Xcode list.

Probably best to revert it for this PR, as you suggest, and discuss this elsewhere so the approved parts can get merged.

@huihuisang
Copy link
Contributor Author

@huihuisang thanks for the work you've done. Totally love the new icons and how it looks.

Can I ask that you leave the platforms button as it was in the bottom left vs at the top toolbar.

Because the platforms window is completely separate, having at the top toolbar doesn't make sense as that toolbar filters, searches, etc the list.

Thanks!

Thank you for your reply. Actually, I don't have a better idea of where this feature should be placed either. The initial modification was just because I felt it looked a bit awkward and took up space at the bottom of the list. Putting it in the top-left corner was to solve this issue. Initially, I also considered that putting it together with the filter button in the top-left corner might not be appropriate. Since I don't have a better idea for now, based on your suggestion, I'll put it back in its original position and make some minor style adjustments so that it doesn't look too abrupt.

@MattKiazyk
Copy link
Contributor

Thanks for the back and forth and the changes - appreciate it!

I may change the Installed Platforms later as I'm working on that platforms view to be more then just the installed ones, but for now 👍

@MattKiazyk MattKiazyk added the enhancement New feature or request label Mar 15, 2024
@MattKiazyk MattKiazyk merged commit bf0dc9d into XcodesOrg:main Mar 15, 2024
1 check passed
@MattKiazyk
Copy link
Contributor

Another Change that would be awesome now is that putting that same default icon on the xcode detail view.

Screenshot 2024-03-15 at 11 27 23 AM

@huihuisang
Copy link
Contributor Author

Another Change that would be awesome now is that putting that same default icon on the xcode detail view.

Screenshot 2024-03-15 at 11 27 23 AM

👌 I'll add it later~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants