Resolve content clipping inside Xcode detail view #539
+45
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why the tests are failed. Seems to be okay. |
|
@LiYanan2004 thanks for your work on this. #540 implements the same margin fixes and includes others, so i'm going to merge that one it. Thanks again! |
|
@MattKiazyk Looks good. But older OS deserves this margin as well because technically it's possible. So I implemented it again. Please check it out😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems
Inside Xcode's detail view, I noticed there is a hard clip, which is annoying to me 🤣.
Fix
Replace
paddingwithcontentPadding(custom modifier using safeArea) to avoid ScrollView's clipping.Comparison
Screen.Recording.2024-03-18.at.10.07.31.mov
Much better.