Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow selecting with short version #115

Merged

Conversation

thii
Copy link
Contributor

@thii thii commented Nov 12, 2020

If a short version is provided, xcodes will select a matched one if
there is only a single match found in the machine. This allows, for
example, if user has Xcode 12.0 GM Seed installed and has no other 12.0
installed, xcodes select 12.0 will select it.

Fixes #114.

If a short version is provided, xcodes will select a matched one if
there is only a single match found in the machine. This allows, for
example, if user has Xcode 12.0 GM Seed installed and has no other 12.0
installed, `xcodes select 12.0` will select it.
@thii thii marked this pull request as ready for review November 12, 2020 01:34
Copy link
Contributor

@interstateone interstateone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to open the issue and submit this PR that implements it, @thii! This is definitely a nice improvement.

I think we could also implement this behaviour for the install (here) and uninstall (here) commands. I know in the past it was unclear to some users that you had to include prerelease identifiers in order to install betas (e.g. 12.3 beta instead of simply 12.3). Is this something you'd be interested in implementing?

edit I've opened #116 to track that.

@interstateone interstateone merged commit 6f1049a into XcodesOrg:master Nov 14, 2020
@thii thii deleted the allow-selecting-with-short-version branch November 14, 2020 05:59
@thii
Copy link
Contributor Author

thii commented Nov 14, 2020

I can take a look at it some time next week. In the meantime, would you mind cutting a release that includes this change? We're migrating from xcode-install and are depending on this behavior.

@interstateone
Copy link
Contributor

Okay. I'd prefer the next version to use this behaviour consistently across the commands, so I'll tackle #116 this weekend and make a new release soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow selecting with short version
2 participants