Use Swift 5.1 and Xcode 11 #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is unnecessary now that Xcode can open Package.swift files directly
|
馃憖 |
|
Xcode 11.2 doesn't or does not include the fix? |
daveanderson
approved these changes
Oct 4, 2019
The fix isn't included in the Swift toolchain shipped with 11.2 beta 1.
Thanks for reminding me, I wanted to file a problem report before adding that. Done now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits, resolves #75.
Notably, building with optimizations (so, release builds) gets stuck building Guaka. This appears to be related to this bug, and a fix has landed here which as of now is in the Swift 5.1 development snapshot toolchains. So two workarounds are to use a prerelease toolchain or build with
-Onone. 馃 the fix ships in an Xcode soon (it's not in 11.2 beta).I opened FB7347879 with this project attached to track and help solve the problem.