Feature/di stub api #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est case for added_since
…pi adapter with dummy repos module to test api calls. ignoring [no-any-unimported] for starlette Request
…odules in python executable and mypy config set to pyproject.toml. update mypy ignore in app.py
…. this is needed to set within project scope virtualenv. this allows setting virtualenv and installing poetry packages locally.
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 3.43%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
codecakes
added
documentation
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
registrations/infrastructure/adapters/api/routers/register_hospital_router.py
Show resolved
Hide resolved
…ernal deployment services
nlinde
approved these changes
Aug 15, 2022
codecakes
added a commit
that referenced
this pull request
Aug 16, 2022
* updated Structure of core project * smaller header style * added geolocation and added_since fields. added application service test case for added_since * Format code with black and isort * commented description on complex regex string * added mypy to poetry, updated precommit. refactored and updates fastapi adapter with dummy repos module to test api calls. ignoring [no-any-unimported] for starlette Request * no need of requirements file. updated pre-commit mypy to resolve to modules in python executable and mypy config set to pyproject.toml. update mypy ignore in app.py * updated readme to add poetry.toml; this is not extensively documented. this is needed to set within project scope virtualenv. this allows setting virtualenv and installing poetry packages locally. * Format code with black and isort * shortened command is easier to reproduce, port and build in CI on external deployment services * adding another dockerfile that works as image for cloud run. updating cors middleware on app server * Format code with black and isort * Add a shebang or a 'shell' directive. * error when it errs * Format code with black and isort Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
codecakes
added a commit
that referenced
this pull request
Aug 19, 2022
* updated Structure of core project * smaller header style * added geolocation and added_since fields. added application service test case for added_since * Format code with black and isort * commented description on complex regex string * added mypy to poetry, updated precommit. refactored and updates fastapi adapter with dummy repos module to test api calls. ignoring [no-any-unimported] for starlette Request * no need of requirements file. updated pre-commit mypy to resolve to modules in python executable and mypy config set to pyproject.toml. update mypy ignore in app.py * updated readme to add poetry.toml; this is not extensively documented. this is needed to set within project scope virtualenv. this allows setting virtualenv and installing poetry packages locally. * Format code with black and isort * shortened command is easier to reproduce, port and build in CI on external deployment services * adding another dockerfile that works as image for cloud run. updating cors middleware on app server * Format code with black and isort * Add a shebang or a 'shell' directive. * error when it errs * Format code with black and isort * WIP:: added m3o dbaas support. Need to implement several TODOs/ * updated repo and parse_to_dict function * refactored hospital_dict * updated exception RecordAlreadyExistsError to fastapi * Format code with black and isort * clean cache use apt-get * Feature/di stub api (#28) * updated Structure of core project * smaller header style * added geolocation and added_since fields. added application service test case for added_since * Format code with black and isort * commented description on complex regex string * added mypy to poetry, updated precommit. refactored and updates fastapi adapter with dummy repos module to test api calls. ignoring [no-any-unimported] for starlette Request * no need of requirements file. updated pre-commit mypy to resolve to modules in python executable and mypy config set to pyproject.toml. update mypy ignore in app.py * updated readme to add poetry.toml; this is not extensively documented. this is needed to set within project scope virtualenv. this allows setting virtualenv and installing poetry packages locally. * Format code with black and isort * shortened command is easier to reproduce, port and build in CI on external deployment services * adding another dockerfile that works as image for cloud run. updating cors middleware on app server * Format code with black and isort * Add a shebang or a 'shell' directive. * error when it errs * Format code with black and isort Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> * Format code with black and isort * 'Refactored by Sourcery' (#31) Co-authored-by: Sourcery AI <> * Format code with black and isort * dockerfile refactors. added and refactored functionality in api, uses bootstrap.py and di_builder. updated logic in m3o repo. * added TODO * Format code with black and isort * add as interface * updated docker compose to have necessary local development env vars * Format code with black and isort * deleted obsolete files * fix DOCUMENTATION_API typo * prod and test version if else Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds working api functionality using a dummy database.
This feature branch introduces some crucial updates to
developbranch :poetry.toml. SeeREADME.md; Lot of modules that were not found previously are now found. See why: https://mypy.readthedocs.io/en/stable/installed_packages.html#using-installed-packages-with-mypy-pep-561pyproject.toml;TODO:
.venvas virtualenv until workaround found.