[Settings] Fix flyout position when ComboBox is aligned to the right #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
建议暂时不要合并，正在尝试更好的解决方案 |
|
还没打算合并，等待你修改完成，今天晚上natsurainko估计会修改一部分代码，注意merge分支哈 |
|
初步实现了根据路径长度计算ComboBox宽度，正在进行更多测试 |
gaviny82
commented
Feb 18, 2023
Comment on lines
90
to
92
| //TODO: combobox.items are not necessarily ComboBoxItems | ||
| // var cont = comboBox.ContainerFromIndex(0); | ||
| // var a = comboBox.ItemContainerGenerator.ContainerFromItem(item); |
There was a problem hiding this comment.
本来应该用ItemContainerGenerator获取容器宽度的，但是这一组API好像已经弃用了（ItemContainerGenerator Class | MS Learn），使用GenerateNext也总是返回null，不确定是不是控件加载顺序的问题。
现在的方法是new TextBlock然后获取DesiredSize加上一个固定的宽度，对于string类型的ComboBoxItem没问题，如果设置了ItemTemplate就不能用。
|
在测试项目中实现了通过ItemContainerGenerator计算最大宽度 使用DataTemplate： 向右对齐： |
|
基本上改完了，还剩最后一个问题：路径过长时应该限制最大宽度。绑定一下MaxWidth就好了 |
gaviny82
changed the title
natsurainko
added a commit
that referenced
this pull request
Feb 19, 2023
xingxing2008
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #30 #28 (partial)