Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move metrics and health checks to separate port #298

Merged
merged 5 commits into from
Oct 4, 2021
Merged

Move metrics and health checks to separate port #298

merged 5 commits into from
Oct 4, 2021

Conversation

simongottschlag
Copy link
Member

This PR moves metrics and health checks to a separate port.

Fixes #297

@simongottschlag simongottschlag added enhancement New feature or request proxy labels Oct 4, 2021
@simongottschlag simongottschlag self-assigned this Oct 4, 2021
@simongottschlag
Copy link
Member Author

@bittrance @phillebaba @NissesSenap no review required, just an fyi.

@coveralls
Copy link

coveralls commented Oct 4, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 90.699% when pulling c07c538 on metrics-port into a9d6480 on main.

semgrep-app[bot]
semgrep-app bot reviewed Oct 4, 2021
View reviewed changes
pkg/config/config.go Outdated Show resolved Hide resolved
semgrep-app[bot]
semgrep-app bot reviewed Oct 4, 2021
View reviewed changes
pkg/config/config.go Outdated Show resolved Hide resolved
@NissesSenap
Copy link
Contributor

Don't forget to update Terrform to match the new metric port, it would be needed for the servicemonitor

@simongottschlag
Copy link
Member Author

Don't forget to update Terrform to match the new metric port, it would be needed for the servicemonitor

I wouldn't dream of it!

@simongottschlag simongottschlag merged commit fce56e7 into main Oct 4, 2021
@simongottschlag simongottschlag deleted the metrics-port branch October 4, 2021 20:37
@simongottschlag simongottschlag mentioned this pull request Oct 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semgrep-app semgrep-app[bot] semgrep-app left review comments

Assignees

@simongottschlag simongottschlag

Labels
enhancement New feature or request proxy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move metrics and healthz to separate port
3 participants
@simongottschlag @coveralls @NissesSenap