Feature Request: ACE Arsenal

[dedmen]

Features: acemod/ACE3#5734
Stats: acemod/ACE3#6110
https://ace3mod.com/wiki/feature/arsenal.html
https://ace3mod.com/wiki/framework/arsenal-framework.html

Full arsenal is easy to implement

Domination/co30_Domination.Altis/x_client/x_f/fn_inventoryopened.sqf

Line 14 in cdaa46c

["Open", true] call bis_fnc_arsenal;

->
[player, player, true] call ace_arsenal_fnc_openBox

The limited arsenal variant is slightly different. ACE Arsenal takes array of all Classnames without categorization. I think BI arsenal does things differently in that regard.

If ACE Arsenal is used then

Domination/co30_Domination.Altis/x_client/x_setupplayer.sqf

Line 899 in cdaa46c

["Preload"] call bis_fnc_arsenal;

is not needed.
and

Domination/co30_Domination.Altis/x_client/x_f/x_ui/fn_recruitbuttonaction.sqf

Line 150 in cdaa46c

_unit addAction [localize "STR_DOM_MISSIONSTRING_1585", {["Open",[true,nil,param [0]]] call bis_fnc_arsenal}, [], -1, false, true, "", "true", 3];

should also be replaced.

[dedmen]

The limited arsenal variant is slightly different. ACE Arsenal takes array of all Classnames without categorization. I think BI arsenal does things differently in that regard.

You definitely should not modify a static variable that is computed at gameStart.

https://ace3mod.com/wiki/framework/arsenal-framework.html#11-adding-virtual-items

[Xeno69]

First of all, uiNamespace variables are getting recreated each time a player connects to a server (because of security concerns, was changed during A2/OA times).

Second, BI does it correctly and puts the virtual arsenal classes into a variable in mission namespace (ace does the same just not mission namespace).
It is never a good idea to just hope that third party users do not change those public variables.

[dedmen]

First of all, uiNamespace variables are getting recreated each time a player connects to a server (because of security concerns, was changed during A2/OA times).

Nope. Not at all. missionNamespace yes. But none of the other namespaces.

Second, BI does it correctly and puts the virtual arsenal classes into a variable in mission namespace (ace does the same just not mission namespace).

ACE arsenal does it so it doesn't have to rescan items each mission restart. Allowing for instant arsenal open without any preloading.
The ACE thing is completly different. It's a list of all existing Items in config. Selecting which items should be displayed is done later.

It is never a good idea to just hope that third party uses do not change those public variables.

Yeah sorry. Oversight by me. I already notified the arsenal author to decide if we should compileFinal that variable in the next update.

[Xeno69]

Believe me, uiNamespace gets deleted when a player connects to a server otherwise one could change whatever he likes in uiNamespace in the single player editor, change scripts or whatever and do nasty things once connected.

It was a major security issue during OA times and BI changed it back then.

Compilefinal is also not a solution.
The extDB3 author added a compileFinal to the only public variable the mod has and broke all missions using it because it was no longer a boolean variable but code.

Anyway, if there is an easier solution to clean the ace arsenal array let me know.

Best solution would be to make the variable a normal mission namespace variable, that would only be filled if needed once per mission.

[dedmen]

The extDB3 author added a compileFinal to the only public variable the mod has and broke all missions using it because it was no longer a boolean variable but code.

Not a concern. no-one should be accessing that variable. And if someone does... His fault.

Believe me, uiNamespace gets deleted when a player connects to a server

I will believe you if you tell me why ACE arsenal works at all if the variable that only get's created once at gameStart gets deleted before being accessed.

Or how all my mods variables are always in uiNamespace although I only set them once at gamestart. If uiNamespace gets deleted like you say. Explain me how the variables keep existing.

Best solution would be to make the variable a normal mission namespace variable, that would only be filled if needed once per mission.

https://ace3mod.com/wiki/framework/arsenal-framework.html#11-adding-virtual-items That is how it works. And works about the same as BI arsenal.

It might very well be like that in OA. But not in A3.

[commy2]

Believe me, uiNamespace gets deleted when a player connects to a server otherwise one could change whatever he likes in uiNamespace in the single player editor, change scripts or whatever and do nasty things once connected.

This is demonstrably wrong. In fact, this not being the case is the only reason compileFinal exists: to cache the functions library in ui namespace while at the same time be unable to inject arbitrary code.