Merging 0.0.4 fork #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging latest features
Merge latest features.
…ttings, updated the tests to use 'should' library, added support for runscope urls within the signature generation
…s: BankAccountNumber is not being sent through. Needs investigation
…mbers. TODO: Delete method hasn't been implemented globally.
This is more readable and concise
This moves the concern of whether or not to emit an event to be internal to setOptions. No need for the calling functions to make that decision.
I'm not sure we should be catching and discarding exceptions from external code. If a consumer of the library causes an exception in their handler, it's up to them to deal with it. The danger with leaving the catch in is that someone hits some fatal condition and they throw an exception in order to take down the application or be handled upstream. Having it eaten inside the Xero lib would be unexpected behaviour.
Cleanup event emission and object assignment.
'1': 'BalanceSheet', '2': 'TrialBalance', '3': 'ProfitAndLoss', '4': 'BankStatement', '5': 'BudgetSummary', '6': 'ExecutiveSummary', '7': 'BankSummary', '8': 'AgedReceivablesByContact', '9': 'AgedPayablesByContact' The missing ones are the 1099 report (US Only) and the GST/BAS report (AU/NZ). These will be added in a subsequent feature release.
Add reports endpoint support and refactor directories.
added support for retrieving branding themes and merged with the reporting and directory changes.
added currencies support
added support for retrieving invoice reminder settings
added name and version to user-agent header
Tests passing. Approved merge.
Prep for pr to master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a vast series of improvements to the current head branch.
This version can be considered alpha for general release.