(feat) Add sobelow into CI for static analysis #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, @log4b! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information. |
log4b
force-pushed
the
feat/add-sast
branch
7 times, most recently
from
3d5af97
to
cbb382d
Compare
itsmegrave
reviewed
Oct 2, 2020
log4b
force-pushed
the
feat/add-sast
branch
3 times, most recently
from
57eb2bd
to
f909548
Compare
log4b
force-pushed
the
feat/add-sast
branch
3 times, most recently
from
e597bc1
to
959c791
Compare
itsmegrave
approved these changes
Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
O objetivo deste PR é adicionar a biblioteca sobelow para realizar a análise estática do código.
Desta forma, conseguimos garantir que vulnerabilidades conhecidas não são inseridas na codebase.
Além disso, durante a alteração, o relatório de coverage levantou que uma função
modnão era coberta em 100% dos cenários. Adicionei o UT referente a mesma para manter o coverage dentro do estabelecido para o projeto.