Sugestões #24
Merged
Sugestões #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunorafa
commented
Dec 16, 2020
Comment on lines
+9
to
+11
| |> rem(mod_factor) | ||
| |> (&(mod_factor - &1)).() | ||
| |> rem(mod_factor) |
There was a problem hiding this comment.
achei bem interessante a estrategia de passar o rem(mod_factor) novamente para evitar que o resultado tenha mais de 1 digito, mas aparentemente só funciona para mod_factor = 10.
iex(30)> rem(10, 10)
0
iex(31)> rem(4, 10)
4
iex(32)> rem(10, 11)
10 <--- isso seria um problema pois não deveria existir um digito verificador de 2 digitos
iex(33)> rem(2, 11)
2
iex(34)> rem(11, 11)
0
There was a problem hiding this comment.
hmmm.. isso pode virar um problema pro banco do brasil.
vou criar uma issue pra refatorar isso :)
brunorafa
commented
Dec 16, 2020
|
|
||
| validating_digit = | ||
| full_account_number | ||
| |> DigitCalculator.calc_numbers(@weigths, false) |
There was a problem hiding this comment.
parecia que o Itau e o santander estavam querendo fazer coisas bem parecidas com uma minima variação em relação a somar os digitos ou nao do resultado.
brunorafa
commented
Dec 16, 2020
itsmegrave
reviewed
Jan 12, 2021
itsmegrave
approved these changes
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abri esse PR mais no intuito de propor algumas sugestões de mudança e evoluir algumas discussões. :)