Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate vertical and horizontal padding #29

Closed
ghost opened this issue Apr 27, 2021 · 1 comment
Closed

Separate vertical and horizontal padding #29

ghost opened this issue Apr 27, 2021 · 1 comment

Comments

@ghost
Copy link

ghost commented Apr 27, 2021

First of all, many thanks for creating this package! It has really helped my project a lot.
I am using the cursor mainly for clicking tens of elements on a page in succession and I have noticed that using paddingPercentage produces several misclicks. After watching puppeteer running without headless mode I suspect that the reason is that the cursor clicks too low or too high vertically.
So my feature request is to introduce separate vertical and horizontal padding percentages, something like:

..., paddingPercentage: {vertical: 5, horizontal: 10} 

or

..., paddingPercentage: [5,10]
@Niek
Copy link
Collaborator

Niek commented Apr 27, 2021

There is already a paddingPercentage option to add padding on the top/bottom and left/right. It would be possible to split those up but that would complicate the code quite a bit. If you have a clean approach (without adding yet another option) please let me know and I'll look at it.

@ghost ghost closed this as completed May 1, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant