Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fixed "Packet encoding of packet ID 78" #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Dymeth
Copy link
Contributor

@Dymeth Dymeth commented Feb 19, 2023

Fixed "Packet encoding of packet ID 78 threw", but is Work In Progress, so:

  • Tested on 1.19.3 only
  • Plugin/build version not changed
  • Doesn't fixed unused WrapperPlayServerEntityMetadata.getMetadata(), just .setMetadata()
  • Not sure about MC-packets packages structure

No time yet to finish and test it all

@@ -41,7 +41,7 @@
<dependency>
<groupId>com.comphenix.protocol</groupId>
<artifactId>ProtocolLib</artifactId>
<version>4.8.0</version>
<version>5.0.0-SNAPSHOT</version>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version 5.0.0-SNAPSHOT doesn't appear to exist anymore as an official ProtocolLib version. 5.0.0 seams to work fine.

Copy link

@Braekpo1nt Braekpo1nt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this on my own server and this change fixes the existing bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants