Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove "relativeDir = defines[kTargetFile].substring(environment.proj… #56

Merged
merged 1 commit into from Nov 12, 2020

Conversation

fightcoder
Copy link
Contributor

remove relativeDir = defines[kTargetFile].substring(environment.projectDir.absolute.path.length + 1);

  1. 这里defines[kTargetFile]在debug与release下得到的值不一样,用substring会越界,造成RangeError;
  2. relativeDir后面再次赋值没有意义,是无用代码;

@fightcoder
Copy link
Contributor Author

1.当作用抽象类抽象方法时,使用DirectMethodInvocation会在编译 (debug、release下不同 )过程中出现问题,虽然可以在其他方面修改代码解决,但是还是直接使用MethodInvocation好一些,而且在dart-sdk最近的更新中,也已经去掉了DirectMethodInvocation这个类;
2.构建TypeParameterType的时候增加node.nullability,避免作用抽象方法的时候,在ast_to_binary.dartvisitTypeParameterType方法调用时node.declaredNullability为null,导致获取index报错。

@kangwang1988
Copy link
Contributor

请将这两个pr分开提交,并针对第二个case提供对应的aop 案例。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants