Skip to content

Commit

Permalink
Fix versions implementation (flutter#7726)
Browse files Browse the repository at this point in the history
  • Loading branch information
dnfield committed Feb 7, 2019
1 parent d292ed6 commit 3c38dd3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
2 changes: 1 addition & 1 deletion lib/ui/versions.cc
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ void GetVersions(Dart_NativeArguments args) {
}

void Versions::RegisterNatives(tonic::DartLibraryNatives* natives) {
natives->Register({{"Versions_getVersions", GetVersions, 1, true}});
natives->Register({{"Versions_getVersions", GetVersions, 0, true}});
}

} // namespace blink
5 changes: 1 addition & 4 deletions testing/dart/versions_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,10 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// HACK: pretend to be dart.ui in order to access its internals
library dart.ui;
import 'dart:ui';

import 'package:test/test.dart';

part '../../lib/ui/versions.dart';

bool _isNotEmpty(String s) {
if (s == null || s.isEmpty) {
return false;
Expand Down

0 comments on commit 3c38dd3

Please sign in to comment.