-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace glide with go modules #10
Conversation
logs from travis-CI: ----------------------------------------------------------------------
FAIL: terror_test.go:109: testTErrorSuite.TestTraceAndLocation
terror_test.go:114:
c.Assert(len(lines), Equals, 23)
... obtained int = 21
... expected int = 23
OOPS: 4 passed, 1 FAILED
--- FAIL: TestT (0.01s)
FAIL
coverage: 75.9% of statements
FAIL github.com/XiaoMi/Gaea/parser/terror 0.012s |
the unit tests is failed, maybe it's caused by version of "github.com/pingcap/errors", you can check it. |
@cx3ptr maybe we can change or delete this test case? when // parser/terror/terror_test.go#L113
func (s *testTErrorSuite) TestTraceAndLocation(c *C) {
defer testleak.AfterTest(c)()
err := example()
stack := errors.ErrorStack(err)
lines := strings.Split(stack, "\n")
c.Assert(len(lines), Equals, 23) // we asserts error stack lines count as 23, 23 may be changed in future.
var containTerr bool
for _, v := range lines {
if strings.Contains(v, "terror_test.go") {
containTerr = true
break
}
}
c.Assert(containTerr, IsTrue)
} |
lgtm |
after change glide to go mod, the quick start docs shoud be update together |
@cx3ptr already updated. |
lgtm |
feat: replace glide with go modules
#8