Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace glide with go modules #10

Merged
merged 6 commits into from
May 30, 2019
Merged

Conversation

sevennt
Copy link
Contributor

@sevennt sevennt commented May 27, 2019

#8

@sevennt
Copy link
Contributor Author

sevennt commented May 27, 2019

make build success, make test fail.

logs from travis-CI:

----------------------------------------------------------------------
FAIL: terror_test.go:109: testTErrorSuite.TestTraceAndLocation
terror_test.go:114:
    c.Assert(len(lines), Equals, 23)
... obtained int = 21
... expected int = 23
OOPS: 4 passed, 1 FAILED
--- FAIL: TestT (0.01s)
FAIL
coverage: 75.9% of statements
FAIL	github.com/XiaoMi/Gaea/parser/terror	0.012s

@niubell
Copy link
Contributor

niubell commented May 27, 2019

the unit tests is failed, maybe it's caused by version of "github.com/pingcap/errors", you can check it.

@sevennt
Copy link
Contributor Author

sevennt commented May 27, 2019

@cx3ptr maybe we can change or delete this test case?

when github.com/pingcap/errors updated, the expected error stack lines is changed. error stack lines may not be a fixed number.

// parser/terror/terror_test.go#L113
func (s *testTErrorSuite) TestTraceAndLocation(c *C) {
	defer testleak.AfterTest(c)()
	err := example()
	stack := errors.ErrorStack(err)
	lines := strings.Split(stack, "\n")
	c.Assert(len(lines), Equals, 23)  // we asserts error stack lines count as 23, 23 may be changed in future.
	var containTerr bool
	for _, v := range lines {
		if strings.Contains(v, "terror_test.go") {
			containTerr = true
			break
		}
	}
	c.Assert(containTerr, IsTrue)
}

@teckick
Copy link
Contributor

teckick commented May 27, 2019

lgtm

@niubell
Copy link
Contributor

niubell commented May 27, 2019

after change glide to go mod, the quick start docs shoud be update together
@sevennt

@sevennt
Copy link
Contributor Author

sevennt commented May 30, 2019

@cx3ptr already updated.

@niubell
Copy link
Contributor

niubell commented May 30, 2019

lgtm

@niubell niubell merged commit ce4f133 into XiaoMi:master May 30, 2019
panhongrainbow pushed a commit to panhongrainbow/Gaea that referenced this pull request Jun 27, 2021
feat: replace glide with go modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants