Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progress height width 属性，支持传入String类型 #1480

Closed
GleanCoder1116 opened this issue Dec 29, 2020 · 0 comments · Fixed by #1486
Closed

Progress height width 属性，支持传入String类型 #1480

GleanCoder1116 opened this issue Dec 29, 2020 · 0 comments · Fixed by #1486
Assignees
@Flcwl
Labels
comp:progress enhancement New feature or request

Comments

@GleanCoder1116
Copy link
Collaborator

GleanCoder1116 commented Dec 29, 2020 •
edited
Loading

Bug 描述
在使用 Progress 组件时；现 width 只支持 number 类型，传入 100%，组件进度条不显示

参考
重现步骤：

  1. 使用 Progress 组件
  2. 属性配置
width={'100%'}

预期行为
期望自适应和父级宽度相同
其他
2.x 和 3.x 都需要修改

解决分支

https://github.com/XiaoMi/hiui/pull/1486/commits
@GleanCoder1116 GleanCoder1116 added the bug Something isn't working label Dec 29, 2020
@GleanCoder1116 GleanCoder1116 changed the title Progress width 属性传入类型优化 Progress width 属性传入 100% 显示异常 Dec 29, 2020
@Flcwl Flcwl self-assigned this Dec 30, 2020
@Flcwl Flcwl added enhancement New feature or request and removed bug Something isn't working labels Dec 30, 2020
@GleanCoder1116 GleanCoder1116 changed the title Progress width 属性传入 100% 显示异常 Progress height width 属性，支持传入String类型 Dec 31, 2020
GleanCoder1116 pushed a commit that referenced this issue Dec 31, 2020
feat: #1480
5365d3a
@GleanCoder1116 GleanCoder1116 linked a pull request Dec 31, 2020 that will close this issue
Feature/#1480: add string type support for BarProgress && update docs #1486
Merged
GleanCoder1116 pushed a commit that referenced this issue Dec 31, 2020
feat: #1480
9de7f9c
GleanCoder1116 added a commit that referenced this issue Dec 31, 2020
@GleanCoder1116
Merge pull request #1486 from XiaoMi/feature/#1480
c229002 
Feature/#1480: add string type support for BarProgress && update docs
@GleanCoder1116 GleanCoder1116 mentioned this issue Dec 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Flcwl Flcwl

Labels
comp:progress enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/#1480: add string type support for BarProgress && update docs XiaoMi/hiui
3 participants
@solarjoker @GleanCoder1116 @Flcwl