feat(select): 新增带搜索情况下，点击叉号按钮时下拉框同时清空(#2945) #2948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyprepare
reviewed
Jul 25, 2024
packages/ui/select/src/Select.tsx
Outdated
| @@ -236,7 +236,7 @@ export const Select = forwardRef<HTMLDivElement | null, SelectProps>( | |||
| onOpen={menuVisibleAction.on} | |||
| onClose={menuVisibleAction.off} | |||
| searchable={searchable} | |||
| keyword={keywordProp} | |||
| keyword={searchValue} | |||
zyprepare
reviewed
Jul 30, 2024
packages/ui/picker/src/Picker.tsx
Outdated
| /** | ||
| * 提供辅助方法的内部引用 | ||
| */ | ||
| innerRef?: React.Ref<HTMLDivElement> |
There was a problem hiding this comment.
HTMLDivElement 改为 useImperativeHandle 中声明的方法，例如：interface PikcerHelper {resetSearch: () => void}
zyprepare
reviewed
Jul 30, 2024
packages/ui/select/src/Select.tsx
Outdated
| customRender, | ||
| ...rest | ||
| }, | ||
| ref | ||
| ) => { | ||
| const i18n = useLocaleContext() | ||
|
|
||
| const innerRef = useRef<HTMLDivElement>() |
There was a problem hiding this comment.
HTMLDivElement 改为上面说的 PikcerHelper
zyprepare
reviewed
Jul 30, 2024
packages/ui/select/src/Select.tsx
Outdated
| @@ -227,7 +229,7 @@ export const Select = forwardRef<HTMLDivElement | null, SelectProps>( | |||
| return ( | |||
| <SelectProvider value={context}> | |||
| <Picker | |||
| ref={ref} | |||
| ref={mergeRefs(ref, innerRef)} | |||
There was a problem hiding this comment.
建议将 innerRef 放在该行下面，另外有了 innerRef 后不需要在使用 mergeRefs
zyprepare
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
搜索非受控模式下支持
closed #2945