Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api后端接口,时快时慢 #89

Closed
silenceper opened this issue Dec 17, 2018 · 1 comment · Fixed by #90
Closed

api后端接口,时快时慢 #89

silenceper opened this issue Dec 17, 2018 · 1 comment · Fixed by #90
Assignees
Labels
enhancement New feature or request

Comments

@silenceper
Copy link
Contributor

装了一下naftis,首先显示是总共36个服务,总pod 39

在刷新一下页面 的接口
/api/services
/api/diagnose
/api/tasktmpls
发现有时候会有10s的请求是从,而有时候就是ms内

@silenceper silenceper changed the title api后端接口,有时候很慢,有时候很快 api后端接口,时快时慢 Dec 17, 2018
@silenceper
Copy link
Contributor Author

跟踪了下,应该是这段代码导致的

func (k *kubeInfo) sync() {
for {
log.Debug("[Kube] sync start", "svcs", len(k.services), "namespace", k.namespace, "time", time.Now())
svcs, err := client.CoreV1().Services(k.namespace).List(metav1.ListOptions{
LabelSelector: "provider!=kubernetes",
})
if err != nil {
// panic(err.Error())
log.Error("[k8s] get services err", "err", err)
}
ns, err := client.CoreV1().Namespaces().List(metav1.ListOptions{
LabelSelector: "provider!=kubernetes",
})
if err != nil {
// panic(err.Error())
log.Error("[k8s] get namespaces err", "err", err)
}
k.mtx.Lock()
k.services = make([]service, 0, len(svcs.Items))
k.wg.Add(len(svcs.Items))
for _, i := range svcs.Items {
go func(i v1.Service) {
s := service{}
s.Service = i
s.Pods = k.Pods(i.Spec.Selector)
k.services = append(k.services, s)
k.wg.Done()
}(i)
}
k.wg.Wait()
k.namespaces = ns.Items
k.mtx.Unlock()
log.Debug("[Kube] sync end", "svcs", len(k.services), "namespace", k.namespace, "time", time.Now())
time.Sleep(k.syncInterval)
}
}

这里加了锁,在读的时候必须等sync结束才能响应。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants