This repository has been archived by the owner on May 10, 2022. It is now read-only.
refactor: using abstract Batch class to refactor all batch api #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foreverneverer
force-pushed
the
simplyAPI-refactorBatch
branch
from
bb60374
to
cac8bd5
Compare
neverchanje
reviewed
Sep 8, 2020
src/main/java/com/xiaomi/infra/pegasus/client/PegasusClient.java
Outdated
Show resolved
Hide resolved
neverchanje
reviewed
Sep 8, 2020
src/main/java/com/xiaomi/infra/pegasus/client/request/BatchDelete.java
Outdated
Show resolved
Hide resolved
neverchanje
reviewed
Sep 8, 2020
src/main/java/com/xiaomi/infra/pegasus/client/request/BatchDelete.java
Outdated
Show resolved
Hide resolved
neverchanje
reviewed
Sep 8, 2020
src/main/java/com/xiaomi/infra/pegasus/client/request/Batch.java
Outdated
Show resolved
Hide resolved
neverchanje
reviewed
Sep 8, 2020
src/main/java/com/xiaomi/infra/pegasus/client/PegasusTableInterface.java
Outdated
Show resolved
Hide resolved
neverchanje
reviewed
Sep 10, 2020
src/main/java/com/xiaomi/infra/pegasus/client/PegasusClientInterface.java
Outdated
Show resolved
Hide resolved
src/main/java/com/xiaomi/infra/pegasus/client/PegasusTableInterface.java
Outdated
Show resolved
Hide resolved
src/main/java/com/xiaomi/infra/pegasus/client/request/Batch.java
Outdated
Show resolved
Hide resolved
src/main/java/com/xiaomi/infra/pegasus/client/request/Batch.java
Outdated
Show resolved
Hide resolved
src/main/java/com/xiaomi/infra/pegasus/client/request/Batch.java
Outdated
Show resolved
Hide resolved
src/main/java/com/xiaomi/infra/pegasus/client/request/Delete.java
Outdated
Show resolved
Hide resolved
neverchanje
reviewed
Sep 10, 2020
src/main/java/com/xiaomi/infra/pegasus/client/request/Batch.java
Outdated
Show resolved
Hide resolved
neverchanje
reviewed
Sep 14, 2020
src/main/java/com/xiaomi/infra/pegasus/client/request/AbstractBatch.java
Outdated
Show resolved
Hide resolved
src/main/java/com/xiaomi/infra/pegasus/client/request/BatchWithResponse.java
Show resolved
Hide resolved
src/main/java/com/xiaomi/infra/pegasus/client/request/Batch.java
Outdated
Show resolved
Hide resolved
src/main/java/com/xiaomi/infra/pegasus/example/BatchSample.java
Outdated
Show resolved
Hide resolved
src/main/java/com/xiaomi/infra/pegasus/example/BatchSample.java
Outdated
Show resolved
Hide resolved
src/main/java/com/xiaomi/infra/pegasus/example/BatchSample.java
Outdated
Show resolved
Hide resolved
neverchanje
reviewed
Sep 15, 2020
neverchanje
previously approved these changes
Sep 16, 2020
neverchanje
approved these changes
Sep 16, 2020
levy5307
approved these changes
Sep 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#122 offer the solution of
batchapi, this pr usingBatchclass refactor all originbatchXXXapi. After refactoring, thebatchapi count reduce to 3 from 12 and can easily transfer other single operation to batch operation.Note: origin
batchapi is markedDeprecated