This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
Add an option to enable Pegasus features #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
acelyc111
commented
Apr 17, 2019
•
acelyc111
commented
- option中增加一个pegasus_data用于标记是否是Pegasus使用的rocksdb数据
- 通过配置化, 使得项目本身可运行于非Pegasus模式下
- 修复部分单测不过的问题(官方版本已修复)
qinzuoyan
previously approved these changes
Apr 17, 2019
acelyc111
requested review from
hycdong,
mentoswang,
neverchanje,
vagetablechicken and
zhangyifan27
neverchanje
reviewed
Apr 18, 2019
| @@ -55,7 +55,8 @@ class TransactionTest : public ::testing::TestWithParam< | |||
| env = new FaultInjectionTestEnv(Env::Default()); | |||
| options.env = env; | |||
| options.concurrent_prepare = std::get<1>(GetParam()); | |||
| dbname = test::TmpDir() + "/transaction_testdb"; | |||
| size_t tid = std::hash<std::thread::id>()(std::this_thread::get_id()); | |||
There was a problem hiding this comment.
这里都加个 TODO(laiyingchun) 吧，标记后面这里要回归成 rocksdb 的 test::PerThreadDBPath
There was a problem hiding this comment.
不需要
因为后面升级的话肯定是以官方分支为基础,再append我们的修改. 这个地方必然是有冲突需要自己解决的, 到时以官方分支为准即可.
| ASSERT_TRUE(Between(c.ApproximateOffsetOf("k03"), 2000, 3000)); | ||
| ASSERT_TRUE(Between(c.ApproximateOffsetOf("k04"), 2000, 3000)); | ||
| ASSERT_TRUE(Between(c.ApproximateOffsetOf("xyz"), 4000, 6100)); | ||
| ASSERT_TRUE(Between(c.ApproximateOffsetOf("k03"), 2000, 3500)); |
There was a problem hiding this comment.
标注一下 attention，this place differs with rocksdb 5.9.2，等 merge 到新版本再去掉
| @@ -970,7 +970,7 @@ TEST_P(DBTestUniversalCompaction, UniversalCompactionCompressRatio2) { | |||
| dbfull()->TEST_WaitForFlushMemTable(); | |||
| dbfull()->TEST_WaitForCompact(); | |||
| } | |||
| ASSERT_LT(TotalSize(), 120000U * 12 * 0.8 + 120000 * 2); | |||
| ASSERT_LT(TotalSize(), 120000U * 12 * 0.82 + 120000 * 2); | |||
neverchanje
approved these changes
Apr 18, 2019
qinzuoyan
approved these changes
Apr 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.