-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor as uri resolver is removed #242
Conversation
"no meta server specified in config [%s].arguments", | ||
section.c_str()); | ||
|
||
dsn::replication::replica_helper::load_meta_servers(meta_servers, "cluster", cluster_name); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
“cluster” 段名改为 "pegasus.clusters" 吧。
首先,这是rdsn之上的pegasus层的语义,所以加pegasus前缀比较合适,类似于pegasus.server。
然后,这是专门用于配置clusters的meta地址列表的,所以后缀用clusters比较合适。
另外,这个字符串因为要在很多地方使用,所以建议用宏或者常量,可以放在base/pegasus_const.h里面。
src/server/info_collector.cpp
Outdated
@@ -34,7 +35,8 @@ info_collector::info_collector() | |||
_meta_servers.group_address()->add(ms); | |||
} | |||
|
|||
_cluster_name = dsn_config_get_value_string("pegasus.collector", "cluster", "", "cluster name"); | |||
_cluster_name = dsn_config_get_value_string( | |||
"pegasus.collector", PEGASUS_CLUSTER_SECTION_NAME.c_str(), "", "cluster name"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里要用"cluster"
Former-commit-id: e3105ec630c9cef5b70f82a9f8755c754f2acd95 [formerly 4b33f36] Former-commit-id: 058bcbd34628d60458ed750abaca57290d37c794
No description provided.