refactor as uri resolver is removed #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shengofsun
requested review from
hycdong,
mentoswang,
neverchanje,
zhangyifan27,
qinzuoyan,
acelyc111 and
vagetablechicken
qinzuoyan
reviewed
Dec 24, 2018
| "no meta server specified in config [%s].arguments", | ||
| section.c_str()); | ||
|
|
||
| dsn::replication::replica_helper::load_meta_servers(meta_servers, "cluster", cluster_name); |
There was a problem hiding this comment.
“cluster” 段名改为 "pegasus.clusters" 吧。
首先，这是rdsn之上的pegasus层的语义，所以加pegasus前缀比较合适，类似于pegasus.server。
然后，这是专门用于配置clusters的meta地址列表的，所以后缀用clusters比较合适。
另外，这个字符串因为要在很多地方使用，所以建议用宏或者常量，可以放在base/pegasus_const.h里面。
qinzuoyan
reviewed
Dec 25, 2018
src/server/info_collector.cpp
Outdated
| @@ -34,7 +35,8 @@ info_collector::info_collector() | |||
| _meta_servers.group_address()->add(ms); | |||
| } | |||
|
|
|||
| _cluster_name = dsn_config_get_value_string("pegasus.collector", "cluster", "", "cluster name"); | |||
| _cluster_name = dsn_config_get_value_string( | |||
| "pegasus.collector", PEGASUS_CLUSTER_SECTION_NAME.c_str(), "", "cluster name"); | |||
neverchanje
previously approved these changes
Dec 25, 2018
qinzuoyan
approved these changes
Dec 25, 2018
neverchanje
approved these changes
Dec 25, 2018
qinzuoyan
pushed a commit
that referenced
this pull request
Feb 27, 2019
neverchanje
pushed a commit
to neverchanje/pegasus
that referenced
this pull request
Jul 13, 2019
Former-commit-id: e3105ec630c9cef5b70f82a9f8755c754f2acd95 [formerly 4b33f36] Former-commit-id: 058bcbd34628d60458ed750abaca57290d37c794
acelyc111
pushed a commit
that referenced
this pull request
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.