This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
bugfix: fix buf2signed/buf2unsigned/buf2double bug #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
approved these changes
Jul 17, 2018
shengofsun
approved these changes
Jul 17, 2018
neverchanje
approved these changes
Jul 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个bug在于没有考虑string末尾没有\0的情况。我们server端数据一般都是blob，末尾不像string有个\0。那么很有可能把一个合法的int判断为不合法。譬如12ad，len=2，本来是合法int，判断为不合法。
后果就是：在做check_and_set或者incr时，将blob转换为int时出错，就会出错。本来check应当ok的，但是解析int出错，check fail，数据没写进去或者没有incr成功。