This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
nfs: remove nfs from service engine, refactor nfs to a single module #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinzuoyan
approved these changes
Aug 1, 2018
shengofsun
requested review from
qinzuoyan and
acelyc111
and removed request for
LoveHeat
qinzuoyan
previously approved these changes
Aug 1, 2018
neverchanje
reviewed
Aug 2, 2018
| @@ -84,7 +84,8 @@ void replica::on_checkpoint_timer() | |||
| (int64_t)_options->log_private_reserve_max_size_mb * 1024 * 1024, | |||
| (int64_t)_options->log_private_reserve_max_time_seconds); | |||
| if (status() == partition_status::PS_PRIMARY) | |||
| _counter_private_log_size->set(_private_log->total_size() / 1000000); | |||
| _counter_private_log_size->set(_private_log->total_size() / | |||
There was a problem hiding this comment.
这个改回来了，我也没明白为啥原来换了一行。
neverchanje
reviewed
Aug 2, 2018
| } | ||
|
|
||
| aio_task_ptr nfs_node::copy_remote_directory(rpc_address remote, | ||
| const std::string &source_dir, |
There was a problem hiding this comment.
接口传 String 参数推荐用 string_view
There was a problem hiding this comment.
之前用的也是string，我就没改。string_view的好处是，传const char*进来，能避免一次拷贝吗？
There was a problem hiding this comment.
是的，行业内一般接口是用的 string_view，像 rocksdb 用的 Slice。内部类无所谓。这个我觉得尽量吧，不行也没关系。
neverchanje
reviewed
Aug 2, 2018
| } | ||
|
|
||
| aio_task_ptr nfs_node::copy_remote_files(rpc_address remote, | ||
| const std::string &source_dir, |
There was a problem hiding this comment.
我理解这个是我们 copy file 的新的接口，替代 dsn_file_copy_remote_files ？那应该用 string_view。
There was a problem hiding this comment.
这个因为有个vectorstd::string, 所以为了看起来一致舒服一些，就用了string了
|
几个问题哈：
|
|
neverchanje
approved these changes
Aug 2, 2018
qinzuoyan
approved these changes
Aug 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.