This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
valgrind: use static-allocated array to store mapping from task_code to task_spec #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
requested review from
shengofsun,
acelyc111,
hycdong,
mentoswang,
qinzuoyan,
vagetablechicken and
zhangyifan27
|
不太赞同这种预分配512个元素的做法，几乎就是在挖坑…… |
|
@shengofsun 你指的是什么坑，我觉得未来也不会超过 512 task_code 了，内存占用也不大。而且其实也只是换了容器的实现方式，未来有更简单的实现或者更明确的需求都可以替换掉。 |
qinzuoyan
reviewed
Oct 16, 2018
src/core/core/task_spec.cpp
Outdated
| { | ||
| return dsn::utils::singleton_vector_store<task_spec *, nullptr>::instance().get(code); | ||
| } | ||
| task_spec *task_spec::get(int code) { return s_task_spec_store[code].get(); } |
There was a problem hiding this comment.
该为：
return code < 512 ? s_task_spec_store[code].get() : nullptr;
|
|
||
| namespace dsn { | ||
|
|
||
| // A sequential storage maps task_code to task_spec. | ||
| static std::array<std::unique_ptr<task_spec>, 512> s_task_spec_store; | ||
|
|
||
| void task_spec::register_task_code(task_code code, | ||
| dsn_task_type_t type, | ||
| dsn_task_priority_t pri, | ||
| dsn::threadpool_code pool) | ||
| { |
There was a problem hiding this comment.
加上： dassert(code < 512, "code = %d", code);
acelyc111
reviewed
Oct 16, 2018
src/core/core/task_spec.cpp
Outdated
| { | ||
| return dsn::utils::singleton_vector_store<task_spec *, nullptr>::instance().get(code); | ||
| } | ||
| task_spec *task_spec::get(int code) { return code < 512 ? s_task_spec_store[code].get() : nullptr; } |
qinzuoyan
approved these changes
Oct 16, 2018
acelyc111
approved these changes
Oct 16, 2018
shengofsun
approved these changes
Oct 16, 2018
vagetablechicken
pushed a commit
to vagetablechicken/rdsn
that referenced
this pull request
Nov 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Valgrind warns that value pointer in
dsn::utils::singleton_vector_store<task_spec *, nullptr>is not deleted after destruction, so we use a static allocated (512 size of capacity, enough for task_code) array ofstd::unique_ptr<task_spec>to replace thesingleton_vector_storeimplementation.valgrind report:
singleton_vector_storeis a complicated container only used for storing task_spec, we removed it also to make the code simple.This PR also suppress the warning of json_helper, see include/dsn/cpp/json_helper.h: