This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
valgrind: fix leaks of task_worker #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
requested review from
qinzuoyan,
acelyc111,
hycdong,
zhangyifan27,
vagetablechicken and
mentoswang
neverchanje
commented
Oct 19, 2018
| @@ -61,10 +61,7 @@ task_queue::task_queue(task_worker_pool *pool, int index, task_queue *inner_prov | |||
| _spec = (threadpool_spec *)&pool->spec(); | |||
| } | |||
|
|
|||
| task_queue::~task_queue() | |||
| { | |||
| perf_counters::instance().remove_counter(_queue_length_counter->full_name()); | |||
There was a problem hiding this comment.
这段代码解释下，_queue_length_counter 本身是一个 perf_counter_wrapper，它析构时会调用
perf_counters::instance().remove_counter(this->full_name());
所以执行顺序是
- task_queue 析构
- _queue_length_counter 被 removed
- _queue_length_counter 析构
- _queue_length_counter 又被 removed，这里是第二次 remove，valgrind 报错 invalid read.
shengofsun
approved these changes
Oct 21, 2018
qinzuoyan
approved these changes
Oct 23, 2018
vagetablechicken
pushed a commit
to vagetablechicken/rdsn
that referenced
this pull request
Nov 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.