This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
replica-server: remove checkpoint dirs when cold backup completed #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
现在冷备份完成后，backup所使用的checkpoint文件夹会一直保留着，占据不必要的存储空间，几乎让存储用量增大一倍。 |
hycdong
reviewed
Jan 14, 2019
| ", old_backup_status = %s", | ||
| new_context->name, | ||
| backup_context->request.backup_id, | ||
| cold_backup_status_to_string(backup_status)); | ||
| backup_context->cancel(); | ||
| _cold_backup_contexts.erase(policy_name); | ||
| on_cold_backup(request, response); | ||
| if (backup_id != 0) { |
There was a problem hiding this comment.
现在的backup_id是开始备份的时间戳吧？所以肯定不是0？
hycdong
previously approved these changes
Jan 14, 2019
neverchanje
reviewed
Jan 14, 2019
| if (status() == partition_status::type::PS_PRIMARY || | ||
| status() == partition_status::type::PS_SECONDARY) { | ||
| cold_backup_context_ptr backup_context = nullptr; | ||
| auto find = _cold_backup_contexts.find(policy_name); | ||
| if (find != _cold_backup_contexts.end()) { | ||
| backup_context = find->second; | ||
| } else { | ||
| if (backup_id == 0) { | ||
| if (status() == partition_status::type::PS_PRIMARY) { |
There was a problem hiding this comment.
感觉这个 check 应该放在 send_backup_request_to_secondary 里面，这样就不用每次调用都写一遍
There was a problem hiding this comment.
也就多写一遍，而且外面确实就需要检查一下，调用这个函数的角色就应当是primary
neverchanje
reviewed
Jan 14, 2019
| } | ||
|
|
||
| for (std::string &d : sub_dirs) { | ||
| std::string dirname = ::dsn::utils::filesystem::get_file_name(d); |
hycdong
previously approved these changes
Jan 14, 2019
neverchanje
previously approved these changes
Jan 14, 2019
neverchanje
reviewed
Jan 14, 2019
| @@ -181,7 +181,7 @@ client:begin_write:id=169,key=k169,value=v169,timeout=0 | |||
| inject:on_aio_call:node=r2,task_code=LPC_WRITE_REPLICATION_LOG_SHARED | |||
| config:{4,r1,[r3]} | |||
|
|
|||
| state:{{r1,pri,4,24},{r3,sec,4,21}} | |||
There was a problem hiding this comment.
因为代码发生变化，造成这里的表现和原来不一致了，导致travis上测试失败。act测试现在就是有这个问题，有些不确定性，后面需要改进一下。
hycdong
approved these changes
Jan 14, 2019
neverchanje
approved these changes
Jan 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to release storage resouces as soon as possiable.