This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
http: bugfix on http_message_parser #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinzuoyan
previously approved these changes
May 31, 2019
10 tasks
hycdong
reviewed
Jun 3, 2019
hycdong
approved these changes
Jun 3, 2019
qinzuoyan
approved these changes
Jun 3, 2019
neverchanje
pushed a commit
that referenced
this pull request
Jun 3, 2019
neverchanje
pushed a commit
that referenced
this pull request
Jun 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bugfix:
fix the case where URL is very long,
message->buffers.size()will unexpectedly be 4, but not 3.This case has been checked in
http_message_parser_test.parse_long_url.fix the assertion where
message->buffers.size() == 3. This is always true if everything works fine, but for robustness, the server will handle this case instead of being killed.This case has been checked in
http_message_parser_test.parse_bad_request.Check Lists:
Unit tests
Works fine on pprof heap profiling.