Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

thirdparty: add curl to help build prometheus #287

Merged
merged 3 commits into from
Aug 1, 2019
Merged

thirdparty: add curl to help build prometheus #287

merged 3 commits into from
Aug 1, 2019

Conversation

ChenQShmily
Copy link
Contributor

prometheus-gateway need "curl.h" to run
so add curl to 3rdparty to build prometheus-cpp

hycdong
hycdong previously approved these changes Aug 1, 2019
@hycdong
Copy link
Contributor

hycdong commented Aug 1, 2019

TODO:

  • add curl package to aliyun

@neverchanje
Copy link
Contributor

neverchanje commented Aug 1, 2019

Why not use apt-get install libcurl. If libcurl is a necessity, build it as minimal as possible, take
https://github.com/cloudera/kudu/blob/master/thirdparty/build-definitions.sh#L632
as a example:

    --prefix=$PREFIX \
    --disable-dict \
    --disable-file \
    --disable-ftp \
    --disable-gopher \
    --disable-imap \
    --disable-ipv6 \
    --disable-ldap \
    --disable-ldaps \
    --disable-manual \
    --disable-pop3 \
    --disable-rtsp \
    --disable-smtp \
    --disable-telnet \
    --disable-tftp \
    --without-librtmp \
    --without-libssh2

You should figure out what is not required and disable them.

@vagetablechicken
Copy link
Member

Why not use apt-get install libcurl

prometheus是附加组件,没必要强制装libcurl吧。之后还是比较想把thirdparty做的更灵活点,不需要下的库就不用下了,下载编译thirdparty是真的久。

@vagetablechicken
Copy link
Member

这个在docker中测过了么?要保证prometheus client能推数据出去,才能证明没有问题

@ChenQShmily
Copy link
Contributor Author

这个在docker中测过了么?要保证prometheus client能推数据出去,才能证明没有问题

测过了,是可以推数据的

@vagetablechicken
Copy link
Member

这个在docker中测过了么?要保证prometheus client能推数据出去,才能证明没有问题

测过了,是可以推数据的

#287 (comment)
参考这个comment,精简下curl的编译吧

@neverchanje neverchanje added area/installation PR or issues related to compilation / build scripts / installation / deployment. component/scripts labels Aug 1, 2019
@neverchanje neverchanje merged commit 95d5d54 into XiaoMi:master Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/installation PR or issues related to compilation / build scripts / installation / deployment.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants