This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 58
thirdparty: add curl to help build prometheus #287
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hycdong
requested review from
hycdong,
acelyc111,
vagetablechicken,
neverchanje and
qinzuoyan
August 1, 2019 01:21
hycdong
previously approved these changes
Aug 1, 2019
TODO:
|
Why not use apt-get install libcurl. If libcurl is a necessity, build it as minimal as possible, take
You should figure out what is not required and disable them. |
prometheus是附加组件,没必要强制装libcurl吧。之后还是比较想把thirdparty做的更灵活点,不需要下的库就不用下了,下载编译thirdparty是真的久。 |
这个在docker中测过了么?要保证prometheus client能推数据出去,才能证明没有问题 |
测过了,是可以推数据的 |
#287 (comment) |
vagetablechicken
approved these changes
Aug 1, 2019
neverchanje
added
area/installation
PR or issues related to compilation / build scripts / installation / deployment.
component/scripts
labels
Aug 1, 2019
neverchanje
approved these changes
Aug 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area/installation
PR or issues related to compilation / build scripts / installation / deployment.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prometheus-gateway need "curl.h" to run
so add curl to 3rdparty to build prometheus-cpp