Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

refactor: make utils decoupled from dsn_runtime #517

Merged
merged 28 commits into from Jul 20, 2020
Merged

refactor: make utils decoupled from dsn_runtime #517

merged 28 commits into from Jul 20, 2020

Conversation

levy5307
Copy link
Contributor

@levy5307 levy5307 commented Jun 29, 2020 •
edited

  1. Code refactor. For more details: 代码重构与化简 #141
  2. Add some unit tests for command manager

@acelyc111
Copy link
Member

I don't know why still keep a dir 'core', let's discuss clearly on #141 before review this pr.

@levy5307
Copy link
Contributor Author

I don't know why still keep a dir 'core', let's discuss clearly on #141 before review this pr.

I will move all the files under core/core to core in the later pull request. And the core/core directory will be removed meanwhile.

@levy5307 levy5307 marked this pull request as draft June 29, 2020 11:11
@levy5307 levy5307 changed the title refactor: move utils to a seperated directory refactor: make utils decoupled from dsn_runtime Jul 15, 2020
@levy5307 levy5307 marked this pull request as ready for review July 15, 2020 10:34
acelyc111
acelyc111 reviewed Jul 16, 2020
View reviewed changes
src/utils/test/configuration.cpp Outdated Show resolved Hide resolved
src/utils/test/file_utils.cpp Outdated Show resolved Hide resolved
src/utils/test/lock.std.cpp Outdated Show resolved Hide resolved
@levy5307 levy5307 marked this pull request as draft July 16, 2020 05:56
@levy5307 levy5307 marked this pull request as ready for review July 16, 2020 06:24
acelyc111
acelyc111 previously approved these changes Jul 16, 2020
View reviewed changes
@levy5307 levy5307 marked this pull request as draft July 16, 2020 07:31
@levy5307 levy5307 marked this pull request as ready for review July 16, 2020 07:43
acelyc111
acelyc111 previously approved these changes Jul 17, 2020
View reviewed changes
neverchanje
neverchanje reviewed Jul 17, 2020
View reviewed changes
src/utils/lockp.std.h Show resolved Hide resolved
src/utils/safe_strerror_posix.cpp Outdated Show resolved Hide resolved
@neverchanje neverchanje merged commit 3163789 into XiaoMi:master Jul 20, 2020
This was referenced Jul 20, 2020
Merged
Merged
@hycdong hycdong mentioned this pull request Aug 17, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@neverchanje neverchanje neverchanje approved these changes

@hycdong hycdong hycdong approved these changes

@acelyc111 acelyc111 acelyc111 left review comments

Assignees
No one assigned
Labels
2.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@levy5307 @acelyc111 @neverchanje @hycdong