This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
configuration: refactor configuration related APIs #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shengofsun
commented
May 17, 2018
shengofsun
commented
- move configuration related APIs from c interface to utility,
- add comments for these APIs
- remove API: dsn_config_dump
move configuration related APIs from c interface to utility, add comments for these APIs
qinzuoyan
reviewed
May 17, 2018
src/core/core/rpc_engine.h
Outdated
| @@ -141,7 +140,7 @@ class rpc_server_dispatcher | |||
| class rpc_engine | |||
| { | |||
| public: | |||
| rpc_engine(configuration_ptr config, service_node *node); | |||
| rpc_engine(service_node *node); | |||
include/dsn/utility/config_api.h
Outdated
| /// dsn_config_xxx function works | ||
| /// | ||
| /// the function is not thread safe. | ||
| bool load_config(const char *file, const char *arguments); |
There was a problem hiding this comment.
改成 dsn_config_load 吧，和后面的都保持一致
LoveHeat
previously approved these changes
May 18, 2018
acelyc111
reviewed
May 18, 2018
src/core/core/global_config.cpp
Outdated
|
|
||
| for (int i = 0; i < kcapacity; i++) { | ||
| for (unsigned int i = 0; i < keys.size(); i++) { |
|
|
||
| /// get the names of all sections | ||
| /// this function is not thread safe if dsn_config_set is concurrently called | ||
| void dsn_config_get_all_sections(/*out*/ std::vector<const char *> §ions); |
There was a problem hiding this comment.
这两个接口比较冗余,看了下后面使用的地方,都是在用不同的方式做一样的事情,应该可以干掉一个
There was a problem hiding this comment.
一个是把值拷出了，更安全。一个是直接用config里面的内存，不安全，但性能好。
LoveHeat
approved these changes
May 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.