This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
feat: add partition guardian to keep one primary and two secondaries #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smityz
reviewed
Jun 25, 2021
Smityz
reviewed
Jun 25, 2021
LGTM |
hycdong
previously approved these changes
Jun 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closed
foreverneverer
changed the title
feat: add partition guardian
feat: add partition guardian to keep one primary and two secondaries
Jul 2, 2021
foreverneverer
suggested changes
Jul 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
collect_replica actually like util method, and create new class for one method is not appropriate, maybe you can consider the refactor again
good idea. I will move collect_replica/construct_replica to be a method outside class |
foreverneverer
approved these changes
Jul 6, 2021
Smityz
approved these changes
Jul 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think some functions in
simple_load_balancer
have nothing to do with load balancer, such as:cure
/collect_replica
/construct_replica
, etc. So I want to remove them eventually.In this pull request, A class named with
partition_guardian
is added, which job is to keep one primary and two secondaries. And movesimple_load_balancer::cure
into it.And I will move
collect_replica
andconstruct_replica
to be a function outside class later.related issue: #848