Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create GitHub PR Template #856

Open
11 tasks
capnramses opened this issue Feb 16, 2024 · 2 comments · Fixed by #885
Open
11 tasks

Create GitHub PR Template #856

capnramses opened this issue Feb 16, 2024 · 2 comments · Fixed by #885
Assignees
@capnramses
Labels
documentation good first issue Good for newcomers

Comments

@capnramses
Copy link
Collaborator

See also #855 for issues

Good descriptions and flow template for PRs.

  • Issue link.
  • 1-2 lines: Why was the work done?
  • bullets: Description of what work was done.
  • Summary of testing done.
  • Any follow-on work required. With links to any Issues created.

Risks

  • This work contains an API-breaking change.
  • Coverage gaps in test suite.
  • Environments/platforms not testing on.
  • Some tests not passing.
  • Security concerns.
  • Other concerns.

PR Checklist

  • CI/CD passing.
  • Addressed any comments.
  • Got good review with approval.
  • Refresh branch from dev, and resolve and conflicts.
  • CI/CD passing and manual testing done after any changes since PR opened.
@capnramses capnramses added the good first issue Good for newcomers label Feb 16, 2024
@capnramses capnramses mentioned this issue Feb 16, 2024
Closed
6 tasks
@capnramses capnramses self-assigned this Feb 16, 2024
@capnramses
Copy link
Collaborator Author

layout suggestion #858

@capnramses
Copy link
Collaborator Author

started branch on fork

@capnramses capnramses linked a pull request Feb 28, 2024 that will close this issue
Pull Request Template #885
Merged
14 tasks
@capnramses capnramses mentioned this issue Feb 28, 2024
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@capnramses capnramses

Labels
documentation good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pull Request Template capnramses/brevitas
1 participant
@capnramses