Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove quantmaxpool #858

Merged
merged 5 commits into from
Feb 22, 2024
Merged

Conversation

capnramses
Copy link
Collaborator

@capnramses capnramses commented Feb 16, 2024

Purpose of this PR

  • Remove unused quantmaxpool functionality. Issue Remove QuantMaxPool #744.
  • Familiarising myself with the dev & PR process by taking a small task.

Changes made in this PR

  • Removed quant_max_pool functionality within files.
  • Deleted 2x pool.py files that only used quant_max_pool functions.
  • Removed import statements referring to the above files and functions.
  • Removed inclusion of the above in handler lists.

Testing Summary

  • Ran all the brevitas_examples tests before and after these edits.
  • Ran a full local nox pass over the tests.
  • Tested this Brevitas branch in a typical quantisation program of my own.

Risk Introduced / Breaking Changes

  • I'm not 100% familiar with how this functionality was used, so I may have some testing gaps.

Pre-Merge Checklist

  • Refresh branch from dev, resolve conflicts.
  • Reviewed own PR and checked code.
  • Initial PR CI/CD passing.
  • Reviewed and approved.
  • Full CI/CD passing.

@capnramses capnramses self-assigned this Feb 16, 2024
@capnramses capnramses changed the title Feat/remove quantmaxpool remove quantmaxpool Feb 16, 2024
@capnramses capnramses linked an issue Feb 16, 2024 that may be closed by this pull request
@Giuseppe5 Giuseppe5 changed the base branch from master to dev February 17, 2024 10:57
@Giuseppe5
Copy link
Collaborator

We always merge PRs to dev and not master :)

@Giuseppe5 Giuseppe5 self-requested a review February 21, 2024 08:47
@capnramses capnramses mentioned this pull request Feb 21, 2024
11 tasks
@Giuseppe5 Giuseppe5 merged commit 4e9a643 into Xilinx:dev Feb 22, 2024
347 checks passed
@capnramses capnramses deleted the feat/remove_quantmaxpool branch February 28, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove QuantMaxPool
2 participants