Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XDMA: Driver won't compile in Ubuntu 19.04 #34

Open
braspatta opened this issue Sep 20, 2019 · 3 comments
Open

XDMA: Driver won't compile in Ubuntu 19.04 #34

braspatta opened this issue Sep 20, 2019 · 3 comments

Comments

@braspatta
Copy link

Driver won't compile under Ubuntu 19.04 (kernel 5.0.0-29).

root@sim-pc:/home/simulation/Documents/lfpd/dma_ip_drivers-master/XDMA/linux-kernel/xdma# sudo make install
Makefile:10: XVC_FLAGS: .
make -C /lib/modules/5.0.0-29-generic/build M=/home/simulation/Documents/lfpd/dma_ip_drivers-master/XDMA/linux-kernel/xdma modules
make[1]: Entering directory '/usr/src/linux-headers-5.0.0-29-generic'
/home/simulation/Documents/lfpd/dma_ip_drivers-master/XDMA/linux-kernel/xdma/Makefile:10: XVC_FLAGS: .
  CC [M]  /home/simulation/Documents/lfpd/dma_ip_drivers-master/XDMA/linux-kernel/xdma/libxdma.o
/home/simulation/Documents/lfpd/dma_ip_drivers-master/XDMA/linux-kernel/xdma/libxdma.c: In function ‘engine_service_shutdown’:
/home/simulation/Documents/lfpd/dma_ip_drivers-master/XDMA/linux-kernel/xdma/libxdma.c:671:2: error: implicit declaration of function ‘swake_up’; did you mean ‘wake_up’? [-Werror=implicit-function-declaration]
  swake_up(&engine->shutdown_wq);
  ^~~~~~~~
  wake_up
/home/simulation/Documents/lfpd/dma_ip_drivers-master/XDMA/linux-kernel/xdma/libxdma.c: In function ‘xdma_xfer_submit’:
/home/simulation/Documents/lfpd/dma_ip_drivers-master/XDMA/linux-kernel/xdma/libxdma.c:3127:4: error: implicit declaration of function ‘swait_event_interruptible_timeout’; did you mean ‘wait_event_interruptible_timeout’? [-Werror=implicit-function-declaration]
    swait_event_interruptible_timeout(xfer->wq,
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    wait_event_interruptible_timeout
cc1: some warnings being treated as errors
make[2]: *** [scripts/Makefile.build:286: /home/simulation/Documents/lfpd/dma_ip_drivers-master/XDMA/linux-kernel/xdma/libxdma.o] Error 1
make[1]: *** [Makefile:1606: _module_/home/simulation/Documents/lfpd/dma_ip_drivers-master/XDMA/linux-kernel/xdma] Error 2
make[1]: Leaving directory '/usr/src/linux-headers-5.0.0-29-generic'
make: *** [Makefile:27: all] Error 2

used the latest version of the repository.

@iDoka
Copy link

iDoka commented Oct 1, 2019

TL;DR: type in console, it helps:

cd XDMA/linux-kernel/xdma
sed -i 's/swake_up/swake_up_one/' libxdma.c
sed -i 's/swait_event_interruptible_timeout/swait_event_interruptible_timeout_exclusive/' libxdma.c
sed -i 's/VERIFY_WRITE,//' cdev_ctrl.c
sed -i 's/VERIFY_READ,//' cdev_ctrl.c

The issue is 5.0 version of linux kernel.

I have the same in Ubuntu 18.04 LTS (kernel 5.0.0-23). Then I found solution here:
https://forums.xilinx.com/t5/PCI-Express/PCIe-DMA-driver-compilation-issues-in-Linux-Ubuntu-19-04/td-p/1022239
and rewrite it with help of sed.

@X-Ryl669
Copy link

See #44 for a clean fix that should work with any version.

@sujathabanoth-xlnx sujathabanoth-xlnx changed the title Driver won't compile in Ubuntu 19.04 XDMA: Driver won't compile in Ubuntu 19.04 Jan 29, 2021
@hmaarrfk
Copy link

Hello,

My name is Mark Harfouche. I am not affiliated with Xilinx in any way. Over the
years of using QDMA, I've been wanted better community organization.

I've created a fork of dma_ip_drivers which I intend to maintain and work with the
community at large to improve.

The fork can be found https://github.com/hmaarrfk/dma_ip_drivers

For now, I am stating the main goals of the repository in
hmaarrfk#2

If you are interested in working together, feel free to open an issue or PR to
my fork.

Best,

Mark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants