Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw on allocate or acquire errors #29

Merged
merged 1 commit into from Jun 27, 2022

Conversation

varunsh-xilinx
Copy link
Member

Style fixes

Summary of Changes

  • Catch exceptions thrown by allocate() and acquire() during worker loading

Closes #28

Motivation

Loading workers can fail for a variety of reasons. Before, only worker exceptions thrown during init() were caught. Now, exceptions thrown in all the initialization methods can be reported back to the client.

Implementation

Try-catch blocks around the methods in question perform local clean-up and then re-throw the exception. It's eventually caught by the Manager and the error is passed to the client.

Some style changes are also implemented to refactor some code and change some function signatures.

@varunsh-xilinx varunsh-xilinx linked an issue Jun 27, 2022 that may be closed by this pull request
@varunsh-xilinx varunsh-xilinx merged commit 270d26a into dev Jun 27, 2022
@varunsh-xilinx varunsh-xilinx deleted the 28-handle-exceptions-on-worker-loading branch June 27, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle exceptions on worker loading
1 participant