Throw on allocate or acquire errors #29
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Style fixes
Summary of Changes
allocate()
andacquire()
during worker loadingCloses #28
Motivation
Loading workers can fail for a variety of reasons. Before, only worker exceptions thrown during
init()
were caught. Now, exceptions thrown in all the initialization methods can be reported back to the client.Implementation
Try-catch blocks around the methods in question perform local clean-up and then re-throw the exception. It's eventually caught by the Manager and the error is passed to the client.
Some style changes are also implemented to refactor some code and change some function signatures.