Build a Python package for the client API #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Varun Sharma <varun.sharma@amd.com>
Refactor dockerfile generator Signed-off-by: Varun Sharma <varun.sharma@amd.com>
Signed-off-by: Varun Sharma <varun.sharma@amd.com>
Signed-off-by: Varun Sharma <varun.sharma@amd.com>
Signed-off-by: Varun Sharma <varun.sharma@amd.com>
Signed-off-by: Varun Sharma <varun.sharma@amd.com>
Update documentation Signed-off-by: Varun Sharma <varun.sharma@amd.com>
varunsh-xilinx
changed the title
|
Build Failed! :( |
Signed-off-by: Varun Sharma <varun.sharma@amd.com>
|
Build Failed! :( |
Signed-off-by: Varun Sharma <varun.sharma@amd.com>
|
Build Failed! :( |
Signed-off-by: Varun Sharma <varun.sharma@amd.com>
|
Build Failed! :( |
Signed-off-by: Varun Sharma <varun.sharma@amd.com>
|
Build Failed! :( |
Signed-off-by: Varun Sharma <varun.sharma@amd.com>
|
Build Failed! :( |
Signed-off-by: Varun Sharma <varun.sharma@amd.com>
|
Build Failed! :( |
|
The build passed after some debugging internally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
cibuildwheelCloses #70
Motivation
Using
cibuildwheelenables us to build wheels for all supported platforms: currently Python 3.6 - 3.11 on manylinux are supported. Building a native wheel enables users to use Python directly or a package manager like conda as desired.Implementation
There are two parts to this PR: templatizing the Dockerfile and then supporting
cibuildwheel.To allow the
manylinuxDocker image to build the server, we need to install our dependencies into it. The image in a CentOS 7 image which was incompatible with our Ubuntu dockerfile. So, the first change is the addition of a generate script that can create a dockerfile that is compatible with Ubuntu (by default, the old behavior is maintained) but now can also generate one that works with a CentOS base image.Now, that we have a
manylinuximage that can build our project, the next set of changes are to build the project. There were a few gotchas:manylinuximage sets_GLIBCXX_USE_CXX11_ABI=0during compilation. There was one location in the code where that had to be checked. In addition,opentelemetrydoesn't seem to work well with this so tracing is entirely removed from the Python wheels until that can be checked further.manylinuxdoesn't link to Python so we need to allow undefined symbols when building it. This also requires CMake 3.18+ to check forDevelopment.ModuleinfindPackage(Python...)auditwheelduring the wheel repair stage for building wheels. The Pybind11 module install location is also changed