Skip to content

Commit

Permalink
tty: xilinx_uartps: Prevent writes when the controller is disabled
Browse files Browse the repository at this point in the history
Prevent writing to the fifo if the controller is disabled.

Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
Link: https://lore.kernel.org/r/20220729114748.18332-6-shubhrajyoti.datta@xilinx.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Shubhrajyoti Datta authored and gregkh committed Aug 30, 2022
1 parent b8a6c3b commit b369628
Showing 1 changed file with 15 additions and 0 deletions.
15 changes: 15 additions & 0 deletions drivers/tty/serial/xilinx_uartps.c
Expand Up @@ -1132,6 +1132,21 @@ static struct uart_driver cdns_uart_uart_driver;
*/
static void cdns_uart_console_putchar(struct uart_port *port, unsigned char ch)
{
unsigned int ctrl_reg;
unsigned long timeout;

timeout = jiffies + msecs_to_jiffies(1000);
while (1) {
ctrl_reg = readl(port->membase + CDNS_UART_CR);
if (!(ctrl_reg & CDNS_UART_CR_TX_DIS))
break;
if (time_after(jiffies, timeout)) {
dev_warn(port->dev,
"timeout waiting for Enable\n");
return;
}
cpu_relax();
}
while (readl(port->membase + CDNS_UART_SR) & CDNS_UART_SR_TXFULL)
cpu_relax();
writel(ch, port->membase + CDNS_UART_FIFO);
Expand Down

0 comments on commit b369628

Please sign in to comment.