Skip to content

Commit

Permalink
pinctrl: zynqmp: Drop pinctrl_unregister for devm_ registered device
Browse files Browse the repository at this point in the history
It's not necessary to unregister pin controller device registered
with devm_pinctrl_register() and using pinctrl_unregister() leads
to a double free.

Fixes: fa99e70 ("pinctrl: zynqmp: some code cleanups")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20210729071905.3235953-1-yangyingliang@huawei.com
  • Loading branch information
Yang Yingliang authored and Michal Simek committed Aug 6, 2021
1 parent feb9c4a commit d06d5c9
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions drivers/pinctrl/pinctrl-zynqmp.c
Expand Up @@ -927,15 +927,6 @@ static int zynqmp_pinctrl_probe(struct platform_device *pdev)
return 0;
}

static int zynqmp_pinctrl_remove(struct platform_device *pdev)
{
struct zynqmp_pinctrl *pctrl = platform_get_drvdata(pdev);

pinctrl_unregister(pctrl->pctrl);

return 0;
}

static const struct of_device_id zynqmp_pinctrl_of_match[] = {
{ .compatible = "xlnx,zynqmp-pinctrl" },
{ }
Expand All @@ -948,7 +939,6 @@ static struct platform_driver zynqmp_pinctrl_driver = {
.of_match_table = zynqmp_pinctrl_of_match,
},
.probe = zynqmp_pinctrl_probe,
.remove = zynqmp_pinctrl_remove,
};
module_platform_driver(zynqmp_pinctrl_driver);

Expand Down

0 comments on commit d06d5c9

Please sign in to comment.