Skip to content

Commit

Permalink
i2c: xiic: Fix the type check for xiic_wakeup
Browse files Browse the repository at this point in the history
Fix the coverity warning
mixed_enum_type: enumerated type mixed with another type

We are passing an enum in the xiic_wakeup lets change
the function parameters to reflect that.

Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
Acked-by: Michal Simek <michal.simek@amd.com>
[wsa: fixed $subject with proper prefix]
Signed-off-by: Wolfram Sang <wsa@kernel.org>
  • Loading branch information
Shubhrajyoti Datta authored and wsakernel committed Jun 14, 2022
1 parent 0d91ac5 commit e749e4f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/i2c/busses/i2c-xiic.c
Expand Up @@ -367,7 +367,7 @@ static void xiic_fill_tx_fifo(struct xiic_i2c *i2c)
}
}

static void xiic_wakeup(struct xiic_i2c *i2c, int code)
static void xiic_wakeup(struct xiic_i2c *i2c, enum xilinx_i2c_state code)
{
i2c->tx_msg = NULL;
i2c->rx_msg = NULL;
Expand All @@ -383,7 +383,7 @@ static irqreturn_t xiic_process(int irq, void *dev_id)
u32 clr = 0;
int xfer_more = 0;
int wakeup_req = 0;
int wakeup_code = 0;
enum xilinx_i2c_state wakeup_code = STATE_DONE;
int ret;

/* Get the interrupt Status from the IPIF. There is no clearing of
Expand Down

0 comments on commit e749e4f

Please sign in to comment.