Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor programming guide bugs, add programming guide lit tests to CI workflows #1509

Merged
merged 19 commits into from
May 29, 2024

Conversation

hunhoffe
Copy link
Collaborator

This PR:

  • Fixes broken examples in the programming guide which were introduced by a recent PR
  • Fixes a few broken links in the repo
  • Improves formatting in a few places in the programming guide
  • Moves existing programming guide lit tests to the run_makefile.lit format
  • Adds an additional lit test or two (some of these are quite trivial, but at least ensure the code builds & runs)
  • Adds ninja check-programming-guide to github CI workflows.

README.md Show resolved Hide resolved
@fifield
Copy link
Collaborator

fifield commented May 23, 2024

Thanks! Can you also add ninja check-programming-guide to buildAndTestRyzenAI.yml?

@hunhoffe
Copy link
Collaborator Author

Thanks! Can you also add ninja check-programming-guide to buildAndTestRyzenAI.yml?

@fifield Added! I thought it was most appropriate to add the check to the build-examples job in that file, but if I should add it to the build-tests job in that file as well, let me know!

Copy link
Collaborator

@jgmelber jgmelber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding lit testing to the rest of the guide and the cleanups!

README.md Show resolved Hide resolved
Copy link
Contributor

@abisca abisca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you for working on this!

@AndraBisca AndraBisca added this pull request to the merge queue May 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 28, 2024
@AndraBisca AndraBisca added this pull request to the merge queue May 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 28, 2024
@fifield fifield added this pull request to the merge queue May 29, 2024
Merged via the queue into Xilinx:main with commit aa2178a May 29, 2024
51 checks passed
singagan pushed a commit that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants