Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aievec] Adding type constraints for aievec::mul_elem operation #1514

Merged
merged 21 commits into from
Jul 10, 2024
Merged

[aievec] Adding type constraints for aievec::mul_elem operation #1514

merged 21 commits into from
Jul 10, 2024

Conversation

muradq-amd
Copy link
Collaborator

  • The previous PR was automatically closed when I tried to hard rest my branch to revert unwanted changes in the [platform/boards] submodule. Here is the link to the previous PR for reference:
  • I rewrote the type constraints for the aievec::mul_elem operation in a simpler way, as we discussed in the last meeting.
  • Changes:
    • Use operand type constraints for lhs, rhs, and acc.
    • Use already implemented predicates in:
      • llvm-project/mlir/include/mlir/IR/OpBase.td
      • llvm-project/mlir/include/mlir/IR/CommonTypeConstraints.td
  • Added Constraints:
    • lhs and rhs operands must match shape.
    • lhs and rhs operands must match type.
    • IsValidAccTypeForAIE2MulElem.

Please let me know if there is a better way to revise these changes.

@muradq-amd muradq-amd requested a review from jsetoain as a code owner May 23, 2024 22:13
@muradq-amd muradq-amd changed the title Adding type constraints for aievec::mul_elem operation [aievec] Adding type constraints for aievec::mul_elem operation Jun 26, 2024
jsetoain
jsetoain requested changes Jul 2, 2024
View reviewed changes
include/aie/Dialect/AIEVec/IR/AIEVecOps.td Outdated Show resolved Hide resolved
include/aie/Dialect/AIEVec/IR/AIEVecTypeConstraints.td Outdated Show resolved Hide resolved
lib/Dialect/AIEVec/Transforms/VectorToAIEVecConversions.cpp Outdated Show resolved Hide resolved
include/aie/Dialect/AIEVec/IR/AIEVecTypeConstraints.td Outdated Show resolved Hide resolved
lib/Dialect/AIEVec/Transforms/VectorToAIEVecConversions.cpp Outdated Show resolved Hide resolved
jsetoain
jsetoain requested changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@jsetoain jsetoain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're almost there! 🙂

include/aie/Dialect/AIEVec/IR/AIEVecTypeConstraints.td Outdated Show resolved Hide resolved
@muradq-amd muradq-amd requested a review from jsetoain July 9, 2024 15:45
@muradq-amd muradq-amd added this pull request to the merge queue Jul 10, 2024
Merged via the queue into Xilinx:main with commit 8065671 Jul 10, 2024
51 checks passed
@muradq-amd muradq-amd deleted the 1171-improve-type-constraints-for-aievecmul_elem-and-co branch July 10, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsetoain jsetoain jsetoain approved these changes

@david-vc david-vc Awaiting requested review from david-vc

@makslevental makslevental Awaiting requested review from makslevental

@jamestcl-amd jamestcl-amd Awaiting requested review from jamestcl-amd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@muradq-amd @jsetoain @jamestcl-amd