[aievec] Add vector.transpose to aievec.shuffle lowering #1527
Conversation
| for (int64_t i = 0; i < static_cast<int64_t>(perm.size() - 2); ++i) | ||
| if (perm[i] != i) | ||
| return failure(); | ||
| if (perm[perm.size() - 1] != static_cast<int64_t>(perm.size() - 2)) |
There was a problem hiding this comment.
Can we do perm.back() here? It's easier to understand. Also, it seems that vector.transpose doesn't prevent you from creating a 0-D vector and empty permutation attribute, so you might want to check the boundary.
There was a problem hiding this comment.
Empty and identity permutations fold away, so they can be safely ignored.
jsetoain
force-pushed
the
lower-transpose-4x8-8x4-to-shuffle
branch
from
48b257e
to
25b1f54
Compare
jsetoain
force-pushed
the
lower-transpose-4x8-8x4-to-shuffle
branch
from
25b1f54
to
7ab4ddd
Compare
jsetoain
force-pushed
the
lower-transpose-4x8-8x4-to-shuffle
branch
from
7ab4ddd
to
3576dfb
Compare
Just for the record, there is no shuffle mode for |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
No description provided.