Skip to content

Commit

Permalink
[chore][exporter/datadog] Update integration_test to test peer service (
Browse files Browse the repository at this point in the history
  • Loading branch information
songy23 authored and XinRanZhAWS committed Mar 13, 2024
1 parent d10cf14 commit d78ca5d
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 2 deletions.
2 changes: 1 addition & 1 deletion exporter/datadogexporter/integrationtest/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ require (
go.opentelemetry.io/otel v1.23.1
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.23.1
go.opentelemetry.io/otel/sdk v1.23.1
go.opentelemetry.io/otel/trace v1.23.1
google.golang.org/protobuf v1.32.0
)

Expand Down Expand Up @@ -171,7 +172,6 @@ require (
go.opentelemetry.io/otel/exporters/stdout/stdouttrace v1.23.0 // indirect
go.opentelemetry.io/otel/metric v1.23.1 // indirect
go.opentelemetry.io/otel/sdk/metric v1.23.0 // indirect
go.opentelemetry.io/otel/trace v1.23.1 // indirect
go.opentelemetry.io/proto/otlp v1.1.0 // indirect
go.uber.org/atomic v1.11.0 // indirect
go.uber.org/multierr v1.11.0 // indirect
Expand Down
14 changes: 13 additions & 1 deletion exporter/datadogexporter/integrationtest/integration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ import (
"go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc"
"go.opentelemetry.io/otel/sdk/resource"
sdktrace "go.opentelemetry.io/otel/sdk/trace"
apitrace "go.opentelemetry.io/otel/trace"
"google.golang.org/protobuf/proto"

"github.com/open-telemetry/opentelemetry-collector-contrib/connector/datadogconnector"
Expand Down Expand Up @@ -121,6 +122,11 @@ func TestIntegration(t *testing.T) {
assert.True(t, strings.HasPrefix(stat.Resource, "TestSpan"))
assert.Equal(t, uint64(1), stat.Hits)
assert.Equal(t, uint64(1), stat.TopLevelHits)
if tt.featureGateEnabled {
// Peer tags aggregation is supported only when the feature gate is enabled (it's enabled by default)
assert.Equal(t, "client", stat.SpanKind)
assert.Equal(t, []string{"extra_peer_tag:tag_val", "peer.service:svc"}, stat.PeerTags)
}
}
}
}
Expand Down Expand Up @@ -194,6 +200,10 @@ processors:
connectors:
datadog/connector:
traces:
compute_stats_by_span_kind: true
peer_tags_aggregation: true
peer_tags: ["extra_peer_tag"]
exporters:
debug:
Expand Down Expand Up @@ -300,7 +310,7 @@ func sendTraces(t *testing.T) {

tracer := otel.Tracer("test-tracer")
for i := 0; i < 10; i++ {
_, span := tracer.Start(ctx, fmt.Sprintf("TestSpan%d", i))
_, span := tracer.Start(ctx, fmt.Sprintf("TestSpan%d", i), apitrace.WithSpanKind(apitrace.SpanKindClient))

if i == 3 {
// Send some traces from a different resource
Expand All @@ -312,6 +322,8 @@ func sendTraces(t *testing.T) {
if i < 5 {
span.SetAttributes(attribute.Bool("sampled", true))
}
span.SetAttributes(attribute.String("peer.service", "svc"))
span.SetAttributes(attribute.String("extra_peer_tag", "tag_val"))
span.End()
}
time.Sleep(1 * time.Second)
Expand Down

0 comments on commit d78ca5d

Please sign in to comment.