Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use startDate for leftmost month in budget view scroll #22

Closed
Xiphe opened this issue Apr 19, 2020 · 2 comments
Closed

Use startDate for leftmost month in budget view scroll #22

Xiphe opened this issue Apr 19, 2020 · 2 comments
Labels
released on @alpha type: 👷internal Improvement to workflows, internal complexity, maintainability
Milestone
Beta

Comments

@Xiphe
Copy link
Owner

Xiphe commented Apr 19, 2020

Currently it is possible to scroll left infinitely. This actually makes no sense since there will not be transactions before that point (hence the name "startDate").

If there is a finite, defined left point then I can use https://react-window.now.sh/ for layouting and jumping to specific entries.

I'd also add an additional leftmost card that says "hey you configured the budget to start here, go to preferences (link) to change this".
@Xiphe Xiphe added this to the Beta milestone Apr 19, 2020
@Xiphe Xiphe added the type: 👷internal Improvement to workflows, internal complexity, maintainability label Apr 19, 2020
@Xiphe
Copy link
Owner Author

Xiphe commented Apr 22, 2020

This should also fix the UX-Bug that I can not click on a unloaded month from a previous year

Xiphe added a commit that referenced this issue Apr 28, 2020
@Xiphe
feat: split out sidebar from scroller
112a708 
in order to have vibrancy background for sidebar

also do not allow scrolling more left before startDate (makes no sense)

fix #22
@Xiphe Xiphe closed this as completed in 33c2ff2 Apr 29, 2020
@github-actions
Copy link

🎉 This issue has been resolved in version 0.2.0-alpha.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Xiphe Xiphe mentioned this issue Apr 29, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released on @alpha type: 👷internal Improvement to workflows, internal complexity, maintainability
Projects
None yet
Milestone
Beta
Development

No branches or pull requests
1 participant
@Xiphe