Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to ignore pending transaction #79

Merged
merged 2 commits into from
Feb 15, 2021
Merged

Add option to ignore pending transaction #79

merged 2 commits into from
Feb 15, 2021

Conversation

leo-benz
Copy link
Contributor

This PR implements feature request #78

Additionally it contains a small improvement to the recently introduced today button

@leo-benz leo-benz marked this pull request as draft February 13, 2021 18:28
@leo-benz
Copy link
Contributor Author

@Xiphe the functionality of the feature is working fine but there is one bug that I can not figure out:
In the settings pane the checkbox for controlling the new feature does not visually toggle from selected to unselected state. The functionality itself is toggling and when reopening the settings panel the state is correctly shown. Toggling from unselected to selected is working fine. It would be great if you could take a look at it.

Xiphe
Xiphe requested changes Feb 15, 2021
View reviewed changes
Copy link
Owner

@Xiphe Xiphe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!
Really appreciate your input 👍

I'd just adjust a few small things.
If you like you could use prettier so that everything is formatted automatically. But im 100% fine doing this afterwards.

src/budget/Types.ts Show resolved Hide resolved
src/moneymoney/calculateBalances.ts Outdated Show resolved Hide resolved
src/views/Budget/Header.tsx Show resolved Hide resolved
src/views/Settings/General/IgnorePendingTransactions.tsx Outdated Show resolved Hide resolved
@leo-benz leo-benz marked this pull request as ready for review February 15, 2021 17:17
@Xiphe Xiphe merged commit 1859141 into Xiphe:beta Feb 15, 2021
@Xiphe
Copy link
Owner

Xiphe commented Feb 15, 2021

🚀 nice work!

@leo-benz leo-benz deleted the feature/78 branch February 15, 2021 17:23
@leo-benz
Copy link
Contributor Author

Thanks for the quick feedback and response to the issues and PRs!

@github-actions
Copy link

🎉 This PR is included in version 1.0.0-beta.15 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xiphe Xiphe Xiphe requested changes

Assignees
No one assigned
Labels
released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leo-benz @Xiphe