Keybind configuration

[Xithrius]

Some users may want different things, so let customization be a thing.

[marcoradocchia]

I'm working on this!

[Xithrius]

Thank you!

[Xithrius]

Keybinds and CLI args have been updated, you might want to rebase.

[marcoradocchia]

Sure, I'll do. Thanks for the warning. I've been a little busy, but I'm slowly working on it. I'll update you soon on the progress.

[Xithrius]

Hey @marcoradocchia, would you still like to work on this?

[marcoradocchia]

Hey @Xithrius ! I'm sorry to not have produced a PR yet. I have made progress, but it still does need some work. Would still like to contribute though, if you want me to. I might have some time tonight to work on it and update you on the status.

[Xithrius]

I have no problem with you working on this. I hope updating your branch from 100 commits behind wasn't too difficult.

[marcoradocchia]

It's fine, I'm working on it right now.
I was thinking about providing the user three TOML tables, one for each mode, like the following:

[keybind.normal]
# Normal keybinds...

[keybind.insert]
# Insert keybinds...

[keybind.dashboard]
# Dashboard keybinds...

What do you think about it?
Also, is there any requirement for the configuration format? Should it be a + separated a string containing key modifiers and a single keycode, maybe like "ALT + CTRL + p", or something else? I would like your opinion about this :)

[Xithrius]

Yeah, I think those tables will work. We can always change them in the future, of course. Along with that, I don't see a problem with the + separated keybinds.

[marcoradocchia]

I have a keybind module, it does serialize/deserialize keybinds to/from TOML.
I've been writing some unit tests for it and they pass. It all seems to work as expected.
The three keybind.normal, keybind.insert and keybind.dashboard tables are now also available for keybind configuration.

I'm going ahead and work on integration now :)

P.S.: Keybind defaults match the currently hardcoded ones.

[marcoradocchia]

Still working on it... I'm sorry for the waiting, in this period I should have more time.

[Xithrius]

No problem! Thank you for the continued updates.

[marcoradocchia]

I'm now trying to update the help widget to dynamically display the configured keybinds. One important question about it: do you have any plans about implementing hot reloading of the configuration file?

[Xithrius]

I don't have any plans at the moment to do so.

[marcoradocchia]

May the user be able to configure multiple keybinds for the same action?
For reference, see:

twitch-tui/src/ui/components/utils/input_widget.rs

Lines 179 to 181 in 2cbb4b8

	Key::Ctrl('f') | Key::Right => {
	self.input.move_forward(1);
	}

[Xithrius]

Yes

[marcoradocchia]

Nice, thanks