Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement request: add default criteria for inclined+nearby moons of ringed planets & for planets very close to their stars #126

Open
Starfire70 opened this issue Nov 22, 2023 · 1 comment
Labels
enhancement New feature or request Explorer

Comments

@Starfire70
Copy link

Inclined moons that are near their ringed gas giant and planets that are near their parent star can be great tourist stops for the view.
Here's what I added to my custom file to cover these.

::Proximity::
scan.Landable and scan.DistanceFromArrivalLS < 20
;the only problem with this is that it won't detect close proximity planets around companion stars
;using semi-major access also triggers for moons around planets which I don't want

::Criteria::
if scan.Landable and scan.OrbitalInclination > 5 and scan.OrbitalPeriod < 2600000 and parents then
if parents[0].Scan and parents[0].ParentType == 'Planet' and parents[0].Scan.Rings then
return true, 'Inclined Moon', ''
end
end
::End::

::Criteria::
if scan.Landable and scan.OrbitalInclination < -5 and scan.OrbitalPeriod < 2600000 and parents then
if parents[0].Scan and parents[0].ParentType == 'Planet' and parents[0].Scan.Rings then
return true, 'Inclined Moon', ''
end
end
::End::

@Xjph
Copy link
Owner

Xjph commented May 11, 2024

Planets very near their parent star should already trigger the close relative orbit criteria for any reasonably large star. 20ls is a bit far for my taste of what I'd consider "close".

Inclined moons is a good one though and I've seen a lot of people adding it as a custom criteria. It may well be time to promote it to default. I'll see if I can squeeze it in.

@Xjph Xjph added enhancement New feature or request Explorer labels Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Explorer
Projects
None yet
Development

No branches or pull requests

2 participants