Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement RotateDeg #50

Merged
merged 3 commits into from
Oct 26, 2023
Merged

implement RotateDeg #50

merged 3 commits into from
Oct 26, 2023

Conversation

KarolosLykos
Copy link
Contributor

Closes #23

@KarolosLykos KarolosLykos mentioned this pull request Oct 24, 2023
Closed
Xkonti
Xkonti requested changes Oct 26, 2023
View reviewed changes
Copy link
Owner

@Xkonti Xkonti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One function could be moved within the file for the sake of consistency (comment). Other than that it looks really good!

rotateDeg.go Show resolved Hide resolved
@KarolosLykos
Copy link
Contributor Author

@Xkonti I've addressed the feedback from the initial review.

Xkonti
Xkonti approved these changes Oct 26, 2023
View reviewed changes
Copy link
Owner

@Xkonti Xkonti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you a lot!

@Xkonti Xkonti merged commit 9e7a7a8 into Xkonti:main Oct 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xkonti Xkonti Xkonti approved these changes

Assignees

@KarolosLykos KarolosLykos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement RotateDeg operation
2 participants
@KarolosLykos @Xkonti