New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8_4] improve error handling and performance of mimalloc #254
Conversation
by register error handler to avoid checking NULL pointer at every allocation. Thus lolly must be initialized by `init_tbox` before any invocation. Therefore many tests are rewritten. Such optimization cannot be performed on jemalloc or fast_alloc.
I do not think it is a perf pr, but it is a pr for better error handling. |
You can disable wasm CI on windows, it is better to do wasm development on linux. I think wasm dev env on Windows is nice to have but it is not necessary. What's your idea on wasm dev env, if you agree my idea, just disable the ci in this pr. |
Could you provide the benchmark result? Null check here is not the bottle neck of performance here.
For error handling, this pr is important for developer to finding bugs for the memory allocator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI failed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PerformanceBefore this pr:
After this pr:
|
by register error handler to avoid checking NULL pointer at every allocation. Thus lolly must be initialized by
init_tbox
before any invocation. Therefore many tests are rewritten.Such optimization cannot be performed on jemalloc or fast_alloc.